Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added one-time signing keys to windows build #8097

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

qstokkink
Copy link
Contributor

Related to #5648

This PR:

  • Fixes the Windows build not being signed at all*.
  • Updates the build action to strip the "v" out of the tag.

I'm not 100% sure if the paths are correct for GitHub Actions but there is only one way to find out 🙂

*Ideally, we would have a beter solution (see #5648) but a cheap signature is still better than none at all.

@qstokkink qstokkink changed the title WIP: Added one-time signing keys to windows build READY: Added one-time signing keys to windows build Aug 20, 2024
@qstokkink qstokkink marked this pull request as ready for review August 20, 2024 10:50
@qstokkink qstokkink marked this pull request as draft August 20, 2024 10:51
@qstokkink
Copy link
Contributor Author

Hold up, typo: "Delf".

@qstokkink
Copy link
Contributor Author

validate

@qstokkink qstokkink marked this pull request as ready for review August 20, 2024 10:55
@qstokkink qstokkink changed the title READY: Added one-time signing keys to windows build Added one-time signing keys to windows build Aug 20, 2024
@qstokkink qstokkink merged commit e46f649 into Tribler:main Aug 20, 2024
6 checks passed
@qstokkink qstokkink deleted the add_ot_signatures branch August 20, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants