Sentry: Disable parse code output #7864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drew2a
requested review from
a team and
egbertbouman
and removed request for
a team
drew2a
force-pushed
the
feature/disable_parse_core_output
branch
from
a1134e3
to
58ef177
Compare
egbertbouman
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR disables (and removes) the parse code output logic introduced in
CoreCrashedErrorfor the Sentry Reporter #7066The reason for this change is that we now have an error code returned along with the CoreCrashedError, making the parsing of core output unnecessary.
CoreCrashedErrorcan now be grouped by the error code, which was previously impossible.While the feature for parsing code output could be improved, it requires more stringent logging rules, which were not supported by team members (see discussion in #7861).