Conversion of error codes to hex for error message formatting. #7862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drew2a
changed the title
drew2a
force-pushed
the
feature/hex_error_code
branch
from
0d2c519
to
e2a0a1e
Compare
- Refactored the `error_code_to_hex` method in `CoreManager` to convert a signed integer error code to a hexadecimal string. - Updated the `format_error_message` method in `CoreManager` to include the converted hex error code in the error message. - Added tests for the new `error_code_to_hex` method, covering both negative and positive error codes.
drew2a
force-pushed
the
feature/hex_error_code
branch
from
e2a0a1e
to
e55afd2
Compare
drew2a
requested review from
a team and
xoriole
and removed request for
a team
xoriole
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds conversion to hex for the error codes.
It will help in investigating issues like #7855, as we will see the hex representation of the error code. This makes it easier to search for the error, especially in the case of Windows. For *nix systems, this change is harmless.
Related issue: #7863