Refactoring query_http_uri
#7846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drew2a
force-pushed
the
fix/7671
branch
2 times, most recently
from
51338cd
to
847e89b
Compare
drew2a
requested review from
a team and
xoriole
and removed request for
a team
xoriole
suggested changes
Jan 25, 2024
src/tribler/core/components/version_check/tests/test_versioncheck.py
Outdated
Show resolved
Hide resolved
xoriole
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating #7671 I found all the places that use the construction
async with ClientSession(...) as session:and consolidated them into a single place to handleServerConnectionError, ClientResponseError, SSLError, ClientConnectorError, asyncio.TimeoutErrorwith a guarantee.Unfortunately, it turns out that the issue that led to the reopening of #7671 was caused by a completely different case.
However, I think this refactoring is worthwhile (though it is up to the reviewer to decide).
A new file named
aiohttp_utils.pyhas been created. The functionsquery_uriandunshortenhave been placed in this file.