Refactor TorrentInfoEndpoint to fix JSON encoding issue #7843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drew2a
requested review from
a team and
xoriole
and removed request for
a team
This was referenced Jan 23, 2024
xoriole
approved these changes
Jan 23, 2024
The code changes in this commit refactor the TorrentInfoEndpoint class in order to fix a JSON encoding issue. The previous implementation used json.dumps, which garbled binary data in the 'pieces' field. This commit removes that line of code and ensures that the GUI does not rely on this field.
drew2a
force-pushed
the
refactoring/get_torrent_info
branch
from
e7c92d3
to
b63f14c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #7823 I realized that there is one instance of dead code and one instance of duplicated code in get_torrent_info, both of which have been removed in this PR, along with disputing comments.