Fix TorrentDefNoMetainfo.get_name_utf8() to return string #7842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xoriole
force-pushed
the
fix/torrentdef
branch
from
696cd9c
to
8f1e383
Compare
xoriole
requested review from
a team and
drew2a
and removed request for
a team
drew2a
approved these changes
Jan 22, 2024
@drew2a could you provide more details on this violation? AFAIK the substitution principle does not apply to constructors. |
|
@qstokkink, you are right; the Liskov Substitution Principle is not applicable to constructors. It was a false alarm. |
|
I apologize to the unknown author of this class 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7836
The downloads response was not JSON serializable because the name was still being returned as bytes in case of serialization of name from torrent def of instance
TorrentDefNoMetainfo. This PR fixes the issue.