Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependencies for application tester to run #7831

Merged
merged 3 commits into from
Jan 17, 2024

Conversation

xoriole
Copy link
Contributor

@xoriole xoriole commented Jan 17, 2024

While fixing the application tester jobs on Jenkins, I found that some dependencies need to be installed to run the application tester from the Tribler repo application tester code. This is a subset of Tribler dependencies.

Several dependencies are required because of the application tester code dependence on TriblerConfig class.

Earlier PR #7824 was used to test if application tester-specific dependencies are installed during tests. It was done by adding an extra dependency requests==2.31.0 and using that dependency in the application tester code. The test is successful and the action run for that is available here.

@xoriole xoriole requested review from a team and drew2a and removed request for a team January 17, 2024 12:28
Copy link
Contributor

@drew2a drew2a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, except the file-read-backwards dependency seems suspicious as it is used only in Tribler and in Exit Node code (NIT).

Please update the readme.md of the Application Tester and add a section about the necessity of installing prerequisites.

@xoriole
Copy link
Contributor Author

xoriole commented Jan 17, 2024

Looks good to me, except the file-read-backwards dependency seems suspicious as it is used only in Tribler and in Exit Node code (NIT).

Please update the readme.md of the Application Tester and add a section about the necessity of installing prerequisites.

Here is the stacktrace for dependency file_read_backwards

/home/user/tribler/venv/bin/python /home/user/tribler/scripts/application_tester/main.py -p python src/run_tribler.py -d 120 
Traceback (most recent call last):
  File "/home/user/tribler/scripts/application_tester/main.py", line 8, in <module>
    from tribler.core.utilities.utilities import make_async_loop_fragile
  File "/home/user/tribler/src/tribler/core/utilities/utilities.py", line 24, in <module>
    from tribler.core.utilities.rest_utils import HTTPS_SCHEME, HTTP_SCHEME, scheme_from_url
  File "/home/user/tribler/src/tribler/core/utilities/rest_utils.py", line 6, in <module>
    from tribler.core.utilities.path_util import Path
  File "/home/user/tribler/src/tribler/core/utilities/path_util.py", line 11, in <module>
    from file_read_backwards import FileReadBackwards
ModuleNotFoundError: No module named 'file_read_backwards'

@xoriole xoriole merged commit c471afc into Tribler:main Jan 17, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants