Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reruns and reruns-delay from pytest arguments #7582

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

xoriole
Copy link
Contributor

@xoriole xoriole commented Aug 22, 2023

Addresses #7581

@xoriole xoriole marked this pull request as ready for review August 23, 2023 08:37
@xoriole xoriole requested review from a team and kozlovsky and removed request for a team August 23, 2023 08:37
@drew2a drew2a merged commit 4871442 into Tribler:main Sep 5, 2023
25 checks passed
@drew2a
Copy link
Contributor

drew2a commented Oct 16, 2023

This PR does not look correct.

To complete the desired change you should also remove the following lines:

pytest-rerunfailures==12.0
pytest-sentry==0.1.16

Otherwise, we'll leave unused artifacts in our code.

Also, we should remove the Sentry project and any related secrets from the Tribler repositories.

@drew2a
Copy link
Contributor

drew2a commented Oct 16, 2023

Workflows that use secrets.PYTEST_SENTRY_DSN have to be updated as well :)

@drew2a
Copy link
Contributor

drew2a commented Oct 16, 2023

Additionally (apologies for these incremental updates), the logic in #7482 might need to be removed. It was initially developed to detect frozen tests, which later turned out to be an issue with pytest-rerunfailures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants