Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ipv8 to the version 2.10 #7285

Merged
merged 3 commits into from
Jan 24, 2023
Merged

Update ipv8 to the version 2.10 #7285

merged 3 commits into from
Jan 24, 2023

Conversation

drew2a
Copy link
Contributor

@drew2a drew2a commented Jan 24, 2023

This PR updates the ipv8 version to the 2.10

Related to #7282

@drew2a
Copy link
Contributor Author

drew2a commented Jan 24, 2023

The cause of the timeout error is test_reject_callback freezes for an unknown reason.

@qstokkink
Copy link
Contributor

qstokkink commented Jan 24, 2023

elif self.request_cache.has("retry", payload.identifier):

Should be changed to:

  elif self.request_cache.has("retry", payload.circuit_id): 

(this is a backward compatible change)

@drew2a drew2a marked this pull request as ready for review January 24, 2023 15:23
@drew2a drew2a requested review from a team, xoriole and kozlovsky and removed request for a team January 24, 2023 15:23
@drew2a drew2a merged commit 87916f7 into main Jan 24, 2023
@drew2a drew2a deleted the feature/update_ipv8 branch January 24, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants