Fixed pip package issues #4769
Merged
Fixed pip package issues #4769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qstokkink
previously approved these changes
Aug 26, 2019
|
Yes, we do. Will update after the tests. |
qstokkink
approved these changes
Aug 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installing pip packages with
--userwithsudoprevilege during installation is causing these packages to be installed for only root, while user simply runs tribler in user mode. This causes those packages not being available in user mode. With this PR, I'm removing the--userflag so it is installed globally and should be available to all users. Moreover,wheelpip dependency is also added which is necessary for systems with older version of pip.Fixes #4767