Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed empty sha on validate action status setting #1264

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Fixed empty sha on validate action status setting #1264

merged 1 commit into from
Jan 17, 2024

Conversation

qstokkink
Copy link
Collaborator

Fixes the issue reported in #1260

This PR:

  • Fixes the actual_pull_head env value from job set_pending_status not being visible to set_failure_status and set_success_status.

@qstokkink
Copy link
Collaborator Author

validate

@qstokkink qstokkink marked this pull request as ready for review January 17, 2024 12:06
@qstokkink qstokkink changed the title WIP: Fixed empty sha on validate action status setting READY: Fixed empty sha on validate action status setting Jan 17, 2024
@qstokkink qstokkink changed the title READY: Fixed empty sha on validate action status setting Fixed empty sha on validate action status setting Jan 17, 2024
@qstokkink qstokkink merged commit 2b581f0 into Tribler:master Jan 17, 2024
7 of 8 checks passed
@qstokkink qstokkink deleted the fix_validate_envshare branch January 17, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egbertbouman egbertbouman egbertbouman approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qstokkink @egbertbouman