Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed validation action errors #1261

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Fixed validation action errors #1261

merged 1 commit into from
Jan 16, 2024

Conversation

qstokkink
Copy link
Collaborator

@qstokkink qstokkink commented Jan 16, 2024 •
edited
Loading

Fixes issues reported in #1260

This PR:

  • Adds target urls for the validation action.
  • Fixes ls-remote to use https://github.com/Tribler/py-ipv8 instead of origin, which doesn't exist.
  • Fixes a missing newline after the ls-remote call.
  • Updates the validation action job order to first set pending status and then start testing.

@qstokkink
Copy link
Collaborator Author

validate

@qstokkink qstokkink changed the title WIP: Fixed validation action errors READY: Fixed validation action errors Jan 16, 2024
@qstokkink qstokkink marked this pull request as ready for review January 16, 2024 13:27
@qstokkink qstokkink changed the title READY: Fixed validation action errors Fixed validation action errors Jan 16, 2024
@qstokkink qstokkink merged commit a1b4173 into Tribler:master Jan 16, 2024
7 checks passed
@qstokkink qstokkink deleted the fix_validationstatus_setting branch January 16, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egbertbouman egbertbouman egbertbouman approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qstokkink @egbertbouman