Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added automatic libsodium.dll downloader for Windows unit tests #1228

Merged
merged 3 commits into from
Oct 17, 2023
Merged

Added automatic libsodium.dll downloader for Windows unit tests #1228

merged 3 commits into from
Oct 17, 2023

Conversation

qstokkink
Copy link
Collaborator

@qstokkink qstokkink commented Oct 17, 2023 •
edited
Loading

Fixes #1227

This PR:

@qstokkink qstokkink force-pushed the add_autoinstall_win_libsodium branch from 26ff85c to c0aaa50 Compare October 17, 2023 12:26
@qstokkink
Copy link
Collaborator Author

validate

@qstokkink qstokkink changed the title WIP: Added automatic libsodium.dll downloader for Windows unit tests READY: Added automatic libsodium.dll downloader for Windows unit tests Oct 17, 2023
@qstokkink qstokkink marked this pull request as ready for review October 17, 2023 12:52
@qstokkink qstokkink changed the title READY: Added automatic libsodium.dll downloader for Windows unit tests Added automatic libsodium.dll downloader for Windows unit tests Oct 17, 2023
@qstokkink qstokkink merged commit 0f98cc5 into Tribler:master Oct 17, 2023
8 checks passed
@qstokkink qstokkink deleted the add_autoinstall_win_libsodium branch October 17, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egbertbouman egbertbouman egbertbouman approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Windows validation action still failing
2 participants
@qstokkink @egbertbouman