Added cryptography-based fallback when NaCL import fails #1225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qstokkink
force-pushed
the
add_nacl_fail_fallback
branch
3 times, most recently
from
ff49f78
to
5b9b763
Compare
qstokkink
force-pushed
the
add_nacl_fail_fallback
branch
from
5b9b763
to
4ace022
Compare
|
This comment should not trigger any action :-) EDIT: but it kind-of did: https://github.com/Tribler/py-ipv8/actions/runs/6518071897/job/17703147864 |
qstokkink
force-pushed
the
add_nacl_fail_fallback
branch
from
4ace022
to
5eb644b
Compare
qstokkink
force-pushed
the
add_nacl_fail_fallback
branch
from
5eb644b
to
31b25c7
Compare
|
validate |
qstokkink
changed the title
egbertbouman
approved these changes
Oct 16, 2023
qstokkink
changed the title
This was referenced Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1224 (fixes Windows, MacOS crashes due to other unknown reasons)
This PR:
python-cryptography-based fallback for whenlibnaclis not found on the system (notably during our validation's matrix tests).macos-latestfrom the validation testing matrix.I'll create a new issue for MacOS.