Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add deprecationReason to relation decorators #352

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

kasir-barati
Copy link
Contributor

Closes #350

@TriPSs I did not add e2e tests for it, do you think it is needed? I tested it manually and confirmed that it will add @deprecated directive to the field.

Copy link

nx-cloud bot commented Jan 26, 2025

View your CI Pipeline Execution ↗ for commit 3e01f6e.

Command Status Duration Result
nx run-many --target=e2e --all ❌ Failed 2m 46s View ↗
nx run-many --target=test --all ✅ Succeeded 42s View ↗
nx run-many --target=lint --all ✅ Succeeded 14s View ↗
nx run-many --target=build --all ✅ Succeeded 4s View ↗
nx run workspace:version ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-26 11:37:39 UTC

@kasir-barati
Copy link
Contributor Author

@TriPSs Just quickly checked the failed pipelines and it seems it is not related to this PR. Cannot we fix this issue of Nx? I guess it fails the pipeline on each cache miss.

@kasir-barati
Copy link
Contributor Author

Is there something I can to do for this PR to get merged @TriPSs 🙂?

@TriPSs
Copy link
Owner

TriPSs commented Jan 28, 2025

I wanne checkout why the tests are failing here before we merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add deprecated option for the relation decorators
2 participants