Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client specific invoice logo #467

Merged
merged 10 commits into from
Aug 24, 2024

Conversation

hussein-mamane
Copy link
Contributor

@hussein-mamane hussein-mamane commented Aug 23, 2024

Description

If User does not add a logo for an invoice, this feature is a fallback that will add add a default invoice logo configured for the specific client, makes it faster to recognize a client's invoices.

Changes

  • added a field in the client_defaults.html form
  • changed client_defaults form to be hx-post from hx-put
  • added an Image field in the ClientDefaults model for the invoice logo
  • changed the change_client_defaults_endpoint and change_client_defaults methods to support POST
  • changed the invoice creation method to use the fallback logo if needed
  • ran black formatter

Warn

Every Time a user change clients defaults the input is empty but the data stays well

Related PRs, Issues etc

@TreyWW
Copy link
Owner

TreyWW commented Aug 24, 2024

Great PR, thanks again! 💜

@TreyWW TreyWW merged commit 3af0066 into TreyWW:main Aug 24, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

implementation: Save a default invoice logo for client
2 participants