Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.4: Sync configure and test setup with bash-5.2 #35

Merged
merged 2 commits into from
Jul 5, 2024

Conversation

jansorg
Copy link
Collaborator

@jansorg jansorg commented Jul 4, 2024

This sync the unit test setup with the bash 5.2 branch to make the output nicer and easier to read.

I've also synced some more of the configure changes and also updated ltmain.sh to the version generated on my local machine (i.e. based on the current autotools(?) stack). But I don't know much about the autotools anymore...

There was a static path in test-cmd-info-variables.sh, which is now fixed to make the tests pass.
I don't know why tests were not failing before this PR, but apparently the unit tests were not executed.

@jansorg jansorg force-pushed the jansorg/4.4/unit-test-setup branch from 13c3743 to 74bc114 Compare July 4, 2024 14:36
@jansorg jansorg force-pushed the jansorg/4.4/unit-test-setup branch from 74bc114 to 2c61c56 Compare July 4, 2024 14:36
@jansorg jansorg changed the title 4.4: sync unit test setup with bash-5.2 4.4: Sync configure and test setup with bash-5.2 Jul 4, 2024
@jansorg jansorg marked this pull request as ready for review July 4, 2024 14:41
@jansorg jansorg requested a review from rocky July 4, 2024 14:41
Copy link
Collaborator

@rocky rocky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks.

@rocky rocky merged commit ce6d463 into bash-4.4 Jul 5, 2024
1 check passed
@jansorg jansorg deleted the jansorg/4.4/unit-test-setup branch December 27, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants