Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose error metric when fetching message #132

Merged

Conversation

Abdulsametileri
Copy link
Member

err := c.r.FetchMessage(c.context, m)
if err != nil {
     if c.context.Err() != nil {
        continue
      }

      c.metric.TotalErrorCountDuringFetchingMessage++
      c.logger.Warnf("Message could not read, err %s", err.Error())
      continue
}

Via this PR, clients use this metric for monitoring and alerting. Because some errors are not recoverable, it means, manual operation is required

# Conflicts:
#	README.md
#	test/integration/go.mod
#	test/integration/go.sum
@Abdulsametileri Abdulsametileri merged commit a5a8628 into v2 Jun 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant