feat: add the default value "MessageGroupDuration" to the README.md (#90

)
Trendyol · Jan 16, 2024 · b6673b9 · b6673b9
1 parent d0a5b26
commit b6673b9
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/README.md b/README.md
@@ -230,7 +230,7 @@ under [the specified folder](examples/with-sasl-plaintext) and then start the ap
 | `commitInterval`                                 | indicates the interval at which offsets are committed to the broker.                                                                  | 1s                          |
 | `rack`                                           | [see doc](https://pkg.go.dev/github.com/segmentio/kafka-go#RackAffinityGroupBalancer)                                                 |                             |
 | `clientId`                                       | [see doc](https://pkg.go.dev/github.com/segmentio/kafka-go#Dialer)                                                                    |                             |
-| `messageGroupDuration`                           | Maximum time to wait for a batch                                                                                                      |                             |
+| `messageGroupDuration`                           | Maximum time to wait for a batch                                                                                                      | 1s                          |
 | `dial.Timeout`                                   | [see doc](https://pkg.go.dev/github.com/segmentio/kafka-go#Dialer)                                                                    | no timeout                  |
 | `dial.KeepAlive`                                 | [see doc](https://pkg.go.dev/github.com/segmentio/kafka-go#Dialer)                                                                    | not enabled                 |
 | `transport.DialTimeout `                         | [see doc](https://pkg.go.dev/github.com/segmentio/kafka-go@#Transport)                                                                | 5s                          |

diff --git a/consumer_config_test.go b/consumer_config_test.go
@@ -26,6 +26,9 @@ func TestConsumerConfig_validate(t *testing.T) {
 		if *cfg.TransactionalRetry != true {
 			t.Fatal("Default Transactional Retry is true")
 		}
+		if cfg.MessageGroupDuration != time.Second {
+			t.Fatal("Message Group Duration default value must equal to 1s")
+		}
 	})
 	t.Run("Set_Defaults_When_Distributed_Tracing_Enabled", func(t *testing.T) {
 		// Given