Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes/landing page #270

Merged
merged 3 commits into from
Feb 14, 2024
Merged

Fixes/landing page #270

merged 3 commits into from
Feb 14, 2024

Conversation

BasVanDeGroep
Copy link
Contributor

Small fixes to landing page & partner page

  • Removed testing borders on a gif on partner page
  • Fixed testimonials loop
  • Removed scrollbars in hamburger menu
  • Removed a few redundant classes
  • Improved responsiveness on CTA section landing page
  • Fixed video not playing, note: File that ended up working is 2MB larger however

@karelvuong
Copy link
Member

@BasVanDeGroep re: the video being larger - seems it increased by 9mb?

@BasVanDeGroep
Copy link
Contributor Author

The 7mb video didn't play for me, this one does.

@karelvuong
Copy link
Member

The 7mb video didn't play for me, this one does.
Cool, got it.

@BasVanDeGroep, separately - seems the build is failing here: https://github.com/TreasureProject/treasure-website/actions/runs/7839298842

@BasVanDeGroep
Copy link
Contributor Author

The 7mb video didn't play for me, this one does.
Cool, got it.

@BasVanDeGroep, separately - seems the build is failing here: https://github.com/TreasureProject/treasure-website/actions/runs/7839298842

Removed the classname prop on this component, seems it was not passed down anywhere. Build went through just now

@karelvuong karelvuong merged commit 5e0867b into master Feb 14, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants