-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bugfix] disable analytics manager on SSR #167
Conversation
🦋 Changeset detectedLatest commit: 654619b The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
Actually now that I'm thinking more about this fix -- this is a bandaid. Should the AnalyticsManager even be running in SSR context? What do we want to track? If i follow the code correctly I think there's technically a memory leak -- on every new render we'd initialize a new AnalyticsManager which invokes a new
|
d986029
to
654619b
Compare
Seeing this error when using this package in a node app. Think we should just be safe and not save to local storage in the even the environment doesn't support it.