Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE]feat: add gas-sponsorship route with basic validations #146

Closed
wants to merge 3 commits into from

Conversation

cdotta
Copy link
Contributor

@cdotta cdotta commented Oct 22, 2024

No description provided.

Copy link

changeset-bot bot commented Oct 22, 2024

⚠️ No Changeset found

Latest commit: 6e043eb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Oct 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tdk-examples-connect ❌ Failed (Inspect) Nov 4, 2024 2:18pm

Body: ValidateBody;
Reply: ValidateReply | ErrorReply;
}>(
"/gas-sponsorship/:partnerId/validate",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow a RESTful or resource-based endpoint design pattern as closely as possible in the TDK API. This endpoint would instead be something like POST /partners/:partnerId/gas-sponsorship

@alecananian
Copy link
Member

Closing until we have a set of rules available for review

@alecananian alecananian closed this Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants