Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update StakingContractMainnet to support vault tokens #11

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

update StakingContractMainnet to support vault tokens #11

wants to merge 12 commits into from

Conversation

alecananian
Copy link
Member

@alecananian alecananian commented Nov 7, 2024 •
edited
Loading

  • StakingContractMainnet was forked from Sushi to enable the LP rewards feature. Currently, it only allows reward tokens to be ERC20. This also allows for Magicswap v2 vault tokens (ERC1155/721 wrapped into ERC20), but the reward calculation has been updated to support vault tokens because we only want users to redeem whole numbers of vault tokens
  • Adds a new claim function that forces skipping of the rounding in case a user wants to pull out all their vault tokens via contract
  • Adds a new NftVaultManager contract to manage depositing to and withdrawing from vaults to streamline incentive creation and rewards claiming

@linear Linear
Copy link

linear bot commented Nov 7, 2024

ENG-659 Contract: update `StakingContractMainnet` to support vault tokens

vmaark
vmaark approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@vmaark vmaark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmaark vmaark vmaark approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alecananian @vmaark @cdotta