Fix new charcodes #110
Merged
Fix new charcodes #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally, attributes were serialized in "game order" (Strength first). At some point the game began serializing these in alphabetical order instead. Since we depended on game order, this swapped attributes around in the resulting tables. Decoding is now based on attribute name rather than any expected order.
Wreckstation
approved these changes
Aug 9, 2023
Wreckstation
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the bad ordering of attribute decodes and adds tests for the decoding of attributes, bonuses. The tests also ensure that a text sheet can be rendered from a character code. The character code tests are extensible by adding more build codes to the list; the tests will be run against each character code separately.