-
Notifications
You must be signed in to change notification settings - Fork 1
Oct 2019 redesign #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@shrubin2 - can you start by resolving the conflicts? I think you're based off an older version of the site. |
@shrubin2 - are their mocks for what the site should look like? It's hard for me to tell if some of the layout is intentionally the way it is. Additionally, now that you've merged with |
Oh, one more note: I'd suggest installing and testing stylelint locally, so you can more quickly iterate on these changes and hopefully get feedback in your editor! Otherwise it'd be pretty time consuming to fix things, push, then wait for Travis until you see if you did everything right or not. |
@shrubin2 - two other notes, since I see Travis is still failing.
Let me know if you have any issues with those! |
This auto-fixed most CI failures
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just doing some manual QA, this looks good on desktop overall, but breaks on mobile. Here's a screenshot of the homepage:
Since mobile is currently working right now, I'd rather you fix the responsiveness of your changes in this PR than have this PR and then have to fix up PR #8. How does that sound?
Cleaned up site, ready for desktop. Still need to make mobile version. I would double check to make sure that buttons go to the right places.
Description of Changes:
How This Was Tested:
Related Issue(s) or Specifications:
Checklist:
Questions / Additional Notes: