Allows fix for issue #19 where Images set are always Template. #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the imageView and headingImageView to be set as is instead of with the UIImageRenderingModeAlwaysTemplate Rendering Mode. Defaults to YES as to not change anything for those who would update to this commit and still want the Rendering Mode defaulting to Template. Fixes issue TransitApp#19 on SVPulsingAnnotationView.
|
Closing this as commit 2638b15 fixes the majority of this issue by making the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically a fix for #19 (Request: Allow non-template Images or Access to the ImageView in some way) which allows for an Boolean value,
setImagesAsTemplate, to be set on theSVPulsingAnnotationViewwhich determines whether images added to theimageViewandheadingImageVieware to be the exact image that you give it, or rendered as Template images. Without this fix, any images given to these Image Views are set with theUIImageRenderingModeAlwaysTemplateRendering Mode.This fix is much better than the subclass "hack" seen in issue #19, with only 4 line changes compared to having to subclass, override two methods, and access the private
imageViewproperty through searching the subviews.The changes don't break anything in the master branch and the new Boolean defaults to YES as to not change anything for those who would update to this commit and still want the Rendering Mode defaulting to Template.