🐛 skip stopovers without geometry (#3148)

Traewelling · Jan 14, 2025 · 0c17764 · 0c17764
1 parent 4b07ee7
commit 0c17764
Showing 1 changed file with 11 additions and 8 deletions.
diff --git a/app/Http/Controllers/Backend/Support/LocationController.php b/app/Http/Controllers/Backend/Support/LocationController.php
@@ -287,16 +287,19 @@ public function calculateDistance(): int {
             $geoJson      = $this->getPolylineBetween();
             $lastStopover = null;
             foreach ($geoJson->features as $stopover) {
-                if ($lastStopover !== null) {
-                    $distance += (new LineSegment(
-                        new Coordinate(
-                            $lastStopover->geometry->coordinates[1],
-                            $lastStopover->geometry->coordinates[0]
-                        ),
-                        new Coordinate($stopover->geometry->coordinates[1], $stopover->geometry->coordinates[0])
-                    ))->calculateDistance();
+                if ($lastStopover === null || !isset($stopover->geometry->coordinates[0]) || !isset($stopover->geometry->coordinates[1])) {
+                    $lastStopover = $stopover;
+                    continue;
                 }
 
+                $distance += (new LineSegment(
+                    new Coordinate(
+                        $lastStopover->geometry->coordinates[1],
+                        $lastStopover->geometry->coordinates[0]
+                    ),
+                    new Coordinate($stopover->geometry->coordinates[1], $stopover->geometry->coordinates[0])
+                ))->calculateDistance();
+
                 $lastStopover = $stopover;
             }
         } catch (JsonException $e) {