Remove the GatherResidentUUIDTask #5378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The API method we used to gather a UUID from a username was apparently removed (but the removal was not documented.) This makes the entire task useless, which is why it is being removed. This PR removes this task, which acted as a way for databases to be filled in. Ultimately, between players having their UUIDs recorded when they log in, and the old-resident-delete feature, 96.7% of servers are reporting UUIDs stored for 90% or more residents. https://bstats.org/plugin/bukkit/Towny/2244 This PR leaves behind a couple of methods in BukkitTools which are unused but could be useful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The API method we used to gather a UUID from a username was apparently
removed (but the removal was not documented.) This makes the entire task
useless, which is why it is being removed. This PR removes this task,
which acted as a way for databases to be filled in.
Ultimately, between players having their UUIDs recorded when they log
in, and the old-resident-delete feature, 96.7% of servers are reporting
UUIDs stored for 90% or more residents.
https://bstats.org/plugin/bukkit/Towny/2244
This PR leaves behind a couple of methods in BukkitTools which are
unused but could be useful.
New Nodes/Commands/ConfigOptions:
Relevant Towny Issue ticket:
Closes #4611
Closes #5375
By making this pull request, I represent that I have the right to waive copyright and related rights to my contribution, and agree that all copyright and related rights in my contributions are waived, and I acknowledge that the TownyAdvanced organization has the copyright to use and modify my contribution under the Towny License for perpetuity.