Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix crash when exception message was is null #174

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tateisu
Copy link

@tateisu tateisu commented Dec 28, 2021

  • I have exterienced a bug when I want to cancel transcode.
  • my code sent thread.interrupt() to the thread that runs transcode. (is there other way?)
  • MediaController's catch block does not check null of ex.getMessage().
java.lang.NullPointerException: println needs a message
        at android.util.Log.println_native(Native Method)
        at android.util.Log.e(Log.java:253)
        at com.iceteck.silicompressorr.videocompression.MediaController.convertVideo(MediaController.java:750)
        at com.iceteck.silicompressorr.videocompression.MediaController.convertVideo(MediaController.java:285)
        at com.iceteck.silicompressorr.SiliCompressor.compressVideo(SiliCompressor.java:214)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant