fix(databricks): update databricks ODBC connector #1344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The certificate does not validate otherwise
Useful for community edition, which is how we test it :p
davinov
added
Need Review
dependencies
PrettyWood
reviewed
Oct 26, 2023
| pwd: SecretStr = Field( | ||
| None, description='Your personal access token', placeholder='dapixxxxxxxxxxx' | ||
| None, |
There was a problem hiding this comment.
je pige pas du coup c'est un champ required non le pwd ? il devrai etre à ... et non None non ? 🤔
There was a problem hiding this comment.
Oui tu as raison, j'ai pas changé cela mais c'est peut-être l'occasion
There was a problem hiding this comment.
euh méfiance je m'étais déja fait cette réflexion et il me semble que parfois on a besoin d'instancier des conecteurs sans secrets... Mais je sais plus pourquoi 😅
fspot
approved these changes
Oct 26, 2023
PrettyWood
approved these changes
Oct 26, 2023
lukapeschke
approved these changes
Oct 26, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I included a very small update of the connector, to be able to change the UID field of the connection string.