Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support column ranges in string format in use_columns #190

Merged
merged 6 commits into from
Feb 27, 2024

Conversation

lukapeschke
Copy link
Collaborator

As discussed, follow-up of #189

@lukapeschke lukapeschke added ✋ need review ✋ 🐍 python 🐍 Pull requests that edit Python code 🦀 rust 🦀 Pull requests that edit Rust code labels Feb 27, 2024
@lukapeschke lukapeschke added this to the v0.10.0 milestone Feb 27, 2024
@lukapeschke lukapeschke self-assigned this Feb 27, 2024
Copy link
Member

@PrettyWood PrettyWood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol I started the PR this morning but didn't have time to finish. You're too fast boiiiiii

python/fastexcel/__init__.py Outdated Show resolved Hide resolved
src/types/excelsheet.rs Show resolved Hide resolved
src/types/excelsheet.rs Outdated Show resolved Hide resolved
src/types/excelsheet.rs Show resolved Hide resolved
python/fastexcel/__init__.py Outdated Show resolved Hide resolved
Signed-off-by: Luka Peschke <[email protected]>
Signed-off-by: Luka Peschke <[email protected]>
Signed-off-by: Luka Peschke <[email protected]>
Copy link
Member

@PrettyWood PrettyWood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work

@PrettyWood PrettyWood merged commit e1fcd7c into main Feb 27, 2024
22 checks passed
@PrettyWood PrettyWood deleted the support-ranges-str-selected-columns branch February 27, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🦀 rust 🦀 Pull requests that edit Rust code 🐍 python 🐍 Pull requests that edit Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants