feat: implemented custom errors #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds custom exception types, which should make error management by users easier closes #45 Signed-off-by: Luka Peschke <[email protected]>
lukapeschke
added
enhancement
PrettyWood
reviewed
Feb 24, 2024
Signed-off-by: Luka Peschke <[email protected]>
Signed-off-by: Luka Peschke <[email protected]>
PrettyWood
requested changes
Feb 25, 2024
There was a problem hiding this comment.
Finally on a computer. the make doc command doesn't work anymore on my machine. Same for you @lukapeschke ? If it's only on my side I'll git into it
Signed-off-by: Luka Peschke <[email protected]>
Signed-off-by: Luka Peschke <[email protected]>
|
@PrettyWood yeah docs still work on my side, see attached artifact. But I added a CI check just in case: 0c67305 |
PrettyWood
approved these changes
Feb 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds custom exception types, which should make error management by users easier
closes #45