[NU-1790] Add sbt task to publish 1.16 compatibility jars #63
Conversation
mslabek
force-pushed
the
NU-1790-add-sbt-task-publish-flink116-kafka-components
branch
3 times, most recently
from
6f08b3c
to
34db039
Compare
mslabek
changed the title
mslabek
force-pushed
the
NU-1790-add-sbt-task-publish-flink116-kafka-components
branch
2 times, most recently
from
b499c3e
to
17961ad
Compare
mslabek
force-pushed
the
NU-1790-add-sbt-task-publish-flink116-kafka-components
branch
from
17961ad
to
e480709
Compare
mslabek
force-pushed
the
NU-1790-add-sbt-task-publish-flink116-kafka-components
branch
from
4e6b989
to
a31fe6b
Compare
mslabek
force-pushed
the
NU-1790-add-sbt-task-publish-flink116-kafka-components
branch
from
a31fe6b
to
ae4b664
Compare
build.sbt
Outdated
| val flink116V = "1.16.0" | ||
| val currentFlinkV = "1.19.1" | ||
| val sttpV = "3.8.11" | ||
| val kafkaV = "3.3.1" | ||
| val testContainersScalaV = "0.41.0" | ||
|
|
||
| ThisBuild / version := "0.1-SNAPSHOT" | ||
| ThisBuild / version := "1.0-nu1.18.0-SNAPSHOT" | ||
|
|
||
| // todo: for now we should regularly bump the version until we start publish single "latest" -SNAPSHOT version | ||
| val defaultNussknackerV = "1.18.0-staging-2024-09-24-20698-40fc17dbe-SNAPSHOT" |
There was a problem hiding this comment.
Its default because it can be overriden by env variable from CI when testing triggered from main repo. I've moved this into nussknackerV scope to make it more clear.
There was a problem hiding this comment.
IMO Nu version should be hardcoded and every time it should be bumped manually (and the change should be reflected with a commit). Like we did in other projects that use Nu as a dependency.
There was a problem hiding this comment.
But then triggering tests from core repo would require pushing a commit to nussknacker-flink-compatibility:staging branch with the tag of the released snapshot image instead of triggering an action? Or do you have another solution in mind?
There was a problem hiding this comment.
I was thinking about the same solution we have in Quickstart and other Nu-related repos:
- there is an instruction in the Release Management guide to bump the project
- there is a master branch with the latest released Nu version
- there is a staging branch with the snapshot version of the Nu version
- Nu core pipeline triggers this pipeline (for the staging branch) to check if the newest staging version of Nu doesn't cause any problems with this repo
No description provided.