Fix assumption that selfref table ID columns are always named "id" #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The recent commit added another fix: If a table has selfref, the |
|
@pjagielski Ping on this PR, I'd really appreciate getting to use this fix along with the other krush changes made since by just using the official krush release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a smaller naming issue that occurred when using M2O-Relations in a selfreference context.
While working on that, I also noticed that ManyToOne-Annotated lists do not currently get filled out by krush (see for example the
childrenattribute in theCategoryexample). This should be fixable by applying M2M selfreference logic (or something similar) to M2O relations as well, but I currently do not have a time to properly try that out.