-
-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat custom parser #352
Closed
Closed
Feat custom parser #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Totodore
force-pushed
the
feat-custom-parser
branch
from
July 25, 2024 21:05
4b4b889
to
7f6b82f
Compare
Closing in favor of #376 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Modify the codebase to have a flexible way to handle new parsers.
Close issue #234.
Solution
A new
Parse
trait with a parser module will contain all the parser implementations.Each implementations will implement the
Parse
trait. They will be enumerated in aParser
enum. Therefore the branching on the chosen parsen will be done with static enum dispatch.The
CommonParser
will be the default parser as for the official socket.io implementation.A future improvement might be to have a better and flexible
Value
type throughout the codebase in order to handle all the different parsers case we might implement. This might also allow the usage of https://docs.rs/serde_json/latest/serde_json/value/struct.RawValue.html for serde_json which would avoid many useless allocations.