Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix(socketio/socket): create a different socket id for each ns" #128

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

Totodore
Copy link
Owner

@Totodore Totodore commented Oct 25, 2023

Reverts #123

It appears that solving this issue implies a big refactoring. Indeed referencing socketio socket with custom sid instead is impossible because of the following architecture :
client recv data from engine socket -> route to corresponding namespace -> route to corresponding socket with <Engine id -> socket> hashmap

Because the socket id is not in the request it is impossible to map socket by their socket id (and not their engine id).
The solution would be to refactor the code to match the official architecture :
client wraps an engine socket and holds a map of the ns -> socket.

@Totodore Totodore merged commit c430b41 into main Oct 25, 2023
8 checks passed
@Totodore Totodore deleted the revert-123-fix-different-sid-for-socketio-ns branch October 30, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant