Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format {verb} on display_scores #607

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Vault108
Copy link
Contributor

Fixes #606

@codecov
Copy link

codecov bot commented Feb 15, 2023

Codecov Report

Base: 79.77% // Head: 79.77% // No change to project coverage 👍

Coverage data is based on head (b4d04fb) compared to base (c46f390).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #607   +/-   ##
=======================================
  Coverage   79.77%   79.77%           
=======================================
  Files         278      278           
  Lines       19377    19377           
  Branches     2250     2250           
=======================================
  Hits        15458    15458           
  Misses       3660     3660           
  Partials      259      259           
Impacted Files Coverage Δ
plugins/duckhunt.py 52.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@linuxdaemon linuxdaemon added needs-test This change needs more testing python Pull requests that update Python code labels Apr 23, 2023
@linuxdaemon
Copy link
Member

Please add test cases to ensure this functions as expected

@Vault108
Copy link
Contributor Author

Please add test cases to ensure this functions as expected

I messaged you on snoonet, how would I go about doing this. Can you point me in the right direction?

@linuxdaemon
Copy link
Member

Please add test cases to ensure this functions as expected

I messaged you on snoonet, how would I go about doing this. Can you point me in the right direction?

Hey, sorry I haven't replied. You can check out

def test_display_scores(mock_db):
which is the current tests for this function. We use the pytest test framework, so you can make the changes locally and then just run python -m pytest to see if they worked. Usually I will write the test, ensure it fails with the current code, and then apply my fix to ensure the test then passes. Make sure to pip install -Ur requirements-dev.txt to install the development dependencies first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-test This change needs more testing python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duckhunt output
2 participants