-
Notifications
You must be signed in to change notification settings - Fork 42
Bevy 0.7 #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bevy 0.7 #17
Conversation
Previously used `render` feature is a group that contains unneeded stuff, like `bevy_ui` or `bevy_text`. Specified features in this PR is the required minimum.
Is the crash an issue upstream with bevy or were you just unable to figure out the cause of it in Also what example are you running to get the crash? I can't seem to reproduce. |
I think that the crash is caused by bevy_debug_lines.
I running |
any progress here? |
It crashes, we don't know how to solve it currently. |
First crash is because bevy switched to u32's for mesh colors, which is a hassle but not too hard to fix. Second issue is that bevy changed seems to require normals, uvs, and probably indices for custom meshes now, at least when using the SpecializedMeshPipeline, all of which would be pointless for us to provide since they aren't used. I'm considering just raising an issue with bevy to not require those properties on meshes that don't need it. P.S: Could be wrong, maybe there's a flag I can set. |
Fix acquired, will push tomorrow-ish. Thanks @superdump! |
Sorry for the delay. Bevy 0.7 should work with master. I feel like the colors may still be off but I'm not sure. I'll push a crate update in a few days once we see if any issues arise. Also, thank you for the pull request! I pulled the relevant changes in but not through GitHub, so I'll close this now. Feel free to comment though. Thanks again! |
This PR contains two changes (separate commits) related to Bevy:
render
feature is a group that contains unneeded stuff, likebevy_ui
orbevy_text
. Specified features in this PR is the required minimum. You can read more about in in this issue: Feature render depends on bevy_ui bevyengine/bevy#4202So the PR is draft.