chore: replace environment variables with package.json entries
#287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sk-
approved these changes
Sep 5, 2024
jbergstroem
force-pushed
the
feat/engines
branch
from
7f6313c
to
f85bc8b
Compare
According to `actions/node-setup`, it will read `manifest.engine` values to decide what node version to use. Second, the lockfile path is only relevant if it is non-default.
jbergstroem
force-pushed
the
feat/engines
branch
from
f85bc8b
to
8ef351f
Compare
|
This should really work according to the code. I'm a bit baffled. Also, node 20 should be default by now.. https://github.com/actions/setup-node/blob/main/src/util.ts#L18-L31 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
This is a work in progress. Do not merge.
According to
actions/node-setup, it will readmanifest.enginevalues to decide what node version to use.Second, the lockfile path is only relevant if it is non-default.
Refs: https://github.com/actions/setup-node/blob/main/docs/advanced-usage.md#node-version-file
Todo
##[debug]Set output node-version = v18.20.4