-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Excesstopography #54
Conversation
To add to that, the windows CI pipeline that builds and test already takes 2 minutes on Windows. I can't say how much of that is building, but I assume adding more (expensive) tests will increase the needed time a lot. |
The CI time is because libtopotoolbox takes forever to build on Windows, which I have also noticed in the libtopotoolbox CI. I don't really know what's going on there: it seems like it spends most of the time configuring the build rather than compiling the library. I'll open an issue over there to remind me to look into it more closely |
I'm with you on not retesting all of the libtopotoolbox functionality: #55 |
In this pull request, the excesstopography function is added to the topotoolbox. I also added some missing type hints to other functions.
Functionality:
fsm2d
andfmm2d
are availablecloses #42
Missing: (for later pull requests)
fmm3d
is not implementeddims
in Passdims
to functions libtopotoolbox#69 and Pass dimensions as an array #53