-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Sphinx docs generation #33
Conversation
I've just taken a quick look here. A few initial thoughts.
|
Ok, I will get started on this. Yes, that will work. They are rarely distributed and just kept in the docs. I will move the examples folder. I don't think it makes much sense to handle this like we did with opensimplex. Since installing the TopoToolbox package has no direct connection to building the docs. Expanding it's section in the readme could be an option, but I still want to find a way to somehow automate it. |
I just updated the versions for the libtopotoolbox documentation. I added a |
The ipynb will not be build since the topotoolbox import is missing
The structure for the future documentation is now created. See: https://teschl.github.io/pytopotoolbox/index.html. Examples are in a gallery with thumbnails, the API docs are created using autosummary. To make them truly functional, #34 has to be implemented. Then I can also start with actually creating a tutorial, for example. @wkearn in my opinion this can be merged in this state, since there isn't really any more information to add. At least that I can think of. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, @Teschl. There are a few things that I think are worth clearing up now (see the comments). The overall framework I think is pretty good. I especially like how the Jupyter notebooks get rendered, and I think that will be useful as we add more documentation.
There are still a few issues relating to documentation which this pull request doesn't completely resolve.
And a few new tasks that this PR creates: |
I addressed the requested changes @wkearn |
This is a first basic implementation of building the docs page with sphinx.
There are still a few issues with this version, so I don't know if we actually want to merge it already. Also, I have not set up a github.io page, that still needs to be added.
/docs
folder. There are a few workarounds for this here, they don't really work for .ipynb files though. This issue is has been open for years now.This uses nbsphinx that is installed separately with pip, how do we want to include this in the requirements?
closes #31