-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows Installation Guide #25
Conversation
Once I get back into the office, I will try to run through this on my Windows computer. I will also try to set up a Windows build on GitHub Actions (#27) and see how that goes. The Windows build instructions are unfortunately complicated, but I guess most users of pytopotoolbox will use It's only developers of the package or people who really want to build the code locally who would need to go through this process, and if they are developing on Windows they probably already have Visual Studio installed. Actually, that does bring up a question: what happens on Linux if you don't have CMake installed? Does scikit-build-core bring its own CMake? If not, it might be useful to mention that dependency. |
When we upload to PyPI it will be as a
As far as I can tell, when cmake is not installed before running the build process, scikit-build-core will automatically install everything that is needed for building. |
The Windows instructions did work for me. You do need to have At some point we could consider changing the pytopotoolbox build step so it doesn't depend on Git. I think that will make more sense once we have a consistent release process for libtopotoolbox so that we could download the appropriate release from somewhere. |
I moved the general install requirements above the OS specific ones.
As far as I understand, CMake can download tar.gz files without using git, so if we provide one with each release this problem should be easy to solve. |
Reorganized Readme.md structure. The Linux Guide is mostly the same as before.
For Windows:
It took quite a while to get Windows to build the package while not crashing during the C/C++ compiling stage. But now that I have got it running, it's pretty straight forward. To make sure that the guide actually works, it would be nice if one of you could follow the steps in the guide, build the package and then just run one of the example files to verify functionality.
For Mac
Since I don't own an Apple Laptop, I can't check if the installation works there too. I assume it works the same as on Linux, but I have no way of knowing. I'll add an issue to track this. (Verify Mac functionality #26 )