Add Identifyflats #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wkearn
requested changes
May 23, 2024
There was a problem hiding this comment.
This looks pretty good! I think having different return types for external and internal use is a good idea for now.
There is one problem with the documentation for identifyflats.
You also need to merge/rebase the latest changes to main: the comments introduced by #23 to grid.cpp are causing a merge conflict.
|
Adjusted the documentation and resolved the merge conflict, should be ready to be merged now. @wkearn |
wkearn
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements
identifyflatsfor theGridObject. To be able to use this function efficiently when creating theFlowObjectI added an argumentrawto just return thendarray.Since there is no way of making a function private in python, I think it's important to still add a function that returns multiple
GridObjects. By using theoutputargument, the number of returned dems can be changed.flats, sills = dem.identifyflats(output=['flats', 'sills'])(default)flats = dem.identifyflats(output=['flats'])sills = dem.identifyflats(output=['sills'])When using
dem.identifyflats(raw=True)instead of multipleGridObjectthe return will be an int32_tnd.ndarray. This also contains presills.Closes #22