Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lombok and documentation #6

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add lombok and documentation #6

wants to merge 2 commits into from

Conversation

okx-code
Copy link

Added lombok to simplify some code as well as documentation in the class DiscordBotListAPI

As well as that, the annotation @Deprecation on getVoters() has been removed, but a warning has been added.

@okx-code
Copy link
Author

@nikammerlaan I was wondering if you've seen this yet?

kayatf
kayatf approved these changes May 6, 2019
View reviewed changes
Copy link

@kayatf kayatf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd consider it a shame on dbl's purpose for not merging the PR🌚

jvtrigueros
jvtrigueros approved these changes Jul 5, 2019
View reviewed changes
Copy link

@jvtrigueros jvtrigueros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvtrigueros jvtrigueros jvtrigueros approved these changes

@kayatf kayatf kayatf approved these changes

@nikammerlaan nikammerlaan Awaiting requested review from nikammerlaan

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@okx-code @jvtrigueros @kayatf