Some Considerable work to update to 1.12.2 #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the gradle file. And The libs.
Mainly deleting useless things, and updated the altar emitter, diviner and manipulator.
… unused ones to a package
With exception to RenderCorruptionCrystallizer
That's way out of my league in terms of ability
Now a part of base Blood Magic mod
Many of these scripts now have homes in the base Blood Magic mod
AhiVT
commented
Jul 30, 2019
|
|
||
| @Mod(modid = Sanguimancy.modid, name = Sanguimancy.name, version = Sanguimancy.version, dependencies = Sanguimancy.depend, guiFactory = "tombenpotter.sanguimancy.client.gui.ConfigGuiFactory") | ||
| public class Sanguimancy { | ||
|
|
There was a problem hiding this comment.
Should be removed as blood tank was the only item using Universal Bucket, now since moved into base Blood Magic
AhiVT
commented
Jul 30, 2019
| @Mod.EventHandler | ||
| public void postInit(FMLPostInitializationEvent event) { | ||
| RecipesRegistry.registerCustomModRecipes(); | ||
| SanguimancyGuide.registerGuide(); |
There was a problem hiding this comment.
GuideAPI has changed a LOT since 1.10, I'm not sure how to register the book now since its no longer static
AhiVT
commented
Jul 30, 2019
| * Used to register crafting recipes to the guide | ||
| */ | ||
| public static IRecipe getLatestCraftingRecipe() { | ||
| IRecipe rec = (IRecipe) CraftingManager.getInstance().getRecipeList().get(CraftingManager.getInstance().getRecipeList().size() - 1); |
There was a problem hiding this comment.
Broken on update to 1.12, couldn't find much info on a migration
AhiVT
commented
Jul 30, 2019
| @@ -1,21 +1,22 @@ | |||
| package tombenpotter.sanguimancy.api.snManifestation; | |||
|
|
|||
| import tombenpotter.sanguimancy.api.objects.BlockPostition; | |||
There was a problem hiding this comment.
BlockPostition obsoleted by Minecraft's built-in BlockPos
AhiVT
commented
Jul 30, 2019
|
|
||
| public class SoulCorruption implements IExtendedEntityProperties { | ||
|
|
||
| public static String ID = "SoulCorruption"; |
There was a problem hiding this comment.
This should probably now be a capability, but the tutorial I was following was particularly unhelpful
AhiVT
commented
Jul 30, 2019
| @@ -1,4 +1,4 @@ | |||
| package tombenpotter.sanguimancy.api.tile; | |||
| package tombenpotter.sanguimancy.api.tiles; | |||
|
I’ve been very busy in the last few years, which is why Sanguimancy hasn’t been updated yet. I’ll take a look at this and see what I can do :)
I’m almost completely done with school, so hopefully that’ll open up some more time I can use to get back into modding!
Le 30 juil. 2019 à 21:59, Joseph Zurowski <[email protected]<mailto:[email protected]>> a écrit :
@Kexerval commented on this pull request.
________________________________
In src/main/java/tombenpotter/sanguimancy/api/tiles/IBoundTile.java<#134 (comment)>:
@@ -1,4 +1,4 @@
-package tombenpotter.sanguimancy.api.tile;
+package tombenpotter.sanguimancy.api.tiles;
Refactor from 1.10.2 branch
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<#134?email_source=notifications&email_token=ABC6P45JFJHOX3ELJRXRYW3QCCMRZA5CNFSM4IH7XH3KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCABQF5Y#pullrequestreview-268632823>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ABC6P45DBV6DSZPRM77UMHDQCCMRZANCNFSM4IH7XH3A>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I really wanted to use this mod in my 1.12 modpack and thought to give a shot at updating the project to 1.12.2. While I'm not in any way new to programming, I barely had any clue where to start with Forge modding. I put forth my best effort to update and fix as much as I could, but there is still much left to be done. It is my hope that pushing my changes to master will catch the eyes of other would-be modders looking to update the mod.