Bump extra-enforcer-rules from 1.5.1 to 1.6.1 #1076
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [extra-enforcer-rules](https://github.com/mojohaus/extra-enforcer-rules) from 1.5.1 to 1.6.1. - [Release notes](https://github.com/mojohaus/extra-enforcer-rules/releases) - [Commits](mojohaus/extra-enforcer-rules@extra-enforcer-rules-1.5.1...extra-enforcer-rules-1.6.1) --- updated-dependencies: - dependency-name: org.codehaus.mojo:extra-enforcer-rules dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
added
the
dependencies
|
The following labels could not be found: |
|
Superseded by #1225. |
dependabot
bot
deleted the
dependabot/maven/org.codehaus.mojo-extra-enforcer-rules-1.6.1
branch
TomaszGaweda
pushed a commit
that referenced
this pull request
May 14, 2024
…572] (#1076) `AddIndexBackupOperation` should be allowed in passive state for the same reason why `AddIndexOperation` is. The issue became visible after improving assertions in https://github.com/hazelcast/hazelcast-mono/pull/1009, before it just failed (with warnings in logs) during proxy initialisation. This is a missing part of https://github.com/hazelcast/hazelcast-mono/pull/596. This PR fixes useless warnings `java.lang.IllegalStateException: Cluster is in PASSIVE state! Operation: com.hazelcast.map.impl.operation.AddIndexBackupOperation`. Map proxy initialization on primary does not fail - backup operation errors are ignored, so indexes should be fine. The only cases where it might matter are: 1. for nodes that do not own any partitions but that is very unlikely (see comment in `AddIndexBackupOperation.runInternal`). 2. if the members are restarted quickly one after another. Backup operation has 5s timeout and in case of backup operation error no response is returned. This may cause MapProxy not being initialized yet when another member joins, so it will not be sent in `PostJoinProxyOperation`. There is a discrepancy in handling `Backup` which contains not-`AllowedDuringPassiveState` operation in PASSIVE state between normal execution (allowed! - does not check nested operation) and offloaded execution (fails with `IllegalStateException` - steps engine checks preconditions for nested operation). That explains the difference between force-offload and normal behavior. This might be fixed separately as it is error prone, but generally our operations should be reasonably defined and not cause problems. Fixes HZ-4582, HZ-4572 Fixes https://github.com/hazelcast/hazelcast-enterprise/issues/7076 Fixes https://github.com/hazelcast/hazelcast-enterprise/issues/7075 GitOrigin-RevId: ef1eec30f3a78f07c0c1e38ae6fbffb482a6a9f4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps extra-enforcer-rules from 1.5.1 to 1.6.1.
Release notes
Sourced from extra-enforcer-rules's releases.
... (truncated)
Commits
45d56eb[maven-release-plugin] prepare release extra-enforcer-rules-1.6.14f6a54cExecute m-invoker-p in run-its profileaaf4120Bump maven-common-artifact-filters from 3.3.0 to 3.3.1be34f37Use all remote repositories for artifacts resolving2ee33d0[maven-release-plugin] prepare for next development iterationf89ea21[maven-release-plugin] prepare release extra-enforcer-rules-1.6.05d10f5cBump mojo-parent from 68 to 698f7eb0fUse shard GitHub actions from Apached342299ignore Maven Core updates3195d55Remove maven-compat from project dependenciesDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)