Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: Allocate logger using tox memory allocator. #2789

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Nov 9, 2024

This change is Reviewable

@iphydf iphydf added this to the v0.2.21 milestone Nov 9, 2024
@github-actions github-actions bot added the cleanup Internal code cleanup, possibly affecting semantics, e.g. deleting a deprecated feature. label Nov 9, 2024
Copy link

codecov bot commented Nov 10, 2024

Codecov Report

Attention: Patch coverage is 86.95652% with 3 lines in your changes missing coverage. Please review.

Project coverage is 73.15%. Comparing base (fa723e3) to head (4ac569b).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
toxcore/logger.c 77.77% 2 Missing ⚠️
toxcore/forwarding_fuzz_test.cc 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2789      +/-   ##
==========================================
+ Coverage   72.96%   73.15%   +0.18%     
==========================================
  Files         149      149              
  Lines       30566    30566              
==========================================
+ Hits        22303    22360      +57     
+ Misses       8263     8206      -57     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iphydf iphydf force-pushed the logger-mem branch 2 times, most recently from 9463003 to e2209fc Compare November 12, 2024 20:41
@toktok-releaser toktok-releaser merged commit bdd17c1 into TokTok:master Nov 13, 2024
64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Internal code cleanup, possibly affecting semantics, e.g. deleting a deprecated feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants