Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: The logger drops frame with the "Success" status. #2765

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

fix: restyled

7081992
Select commit
Loading
Failed to load commit list.
Open

fix: The logger drops frame with the "Success" status. #2765

fix: restyled
7081992
Select commit
Loading
Failed to load commit list.
Mergeable / Mergeable succeeded Nov 9, 2024 in 9s

3 checks passed!

Status: PASS

Details

✔️ Validator: TITLE

  • ✔️ All the requisite validations passed for 'or' option
    Input : fix: The logger drops frame with the "Success" status.
    Settings : {"or":[{"must_include":{"regex":"^(feat|docs|chore|cleanup|fix|refactor|test|style|perf)(\\([^) ]+\\))?:\\ .+$","message":"Semantic release conventions must be followed."}},{"must_include":{"regex":"^Bump [^ ]* from [^ ]* to [^ ]*$","message":"Dependabot PRs are exempt from semantic release conventions."}}]}

✔️ Validator: COMMIT

  • ✔️ Your commit messages met the specified criteria
    Input : fix: Add more information on why the frame was not sent.,fix: Linter fixes,fix: Linter,fix: cimple,fix: restyled
    Settings : {"do":"commit","message":{"regex":"^((feat|docs|chore|cleanup|fix|refactor|test|style|perf)(\\([^) ]+\\))?:\\ .+|Bump [^ ]* from [^ ]* to [^ ]*)","message":"Semantic release conventions must be followed."}}

✔️ Validator: DESCRIPTION

  • ✔️ description must exclude '\[ \]'
    Input : Issue: When the frame is dropped during the video call non informative message is logged:
    [04:15:03.304 UTC] rtp.c:842 : Warning: RTP send failed (len: 1373)! net error: Success

Solution: In this PR I have added logging of custom toxcore error in addition to network error, which is not necessary contains the error code.

Please see corresponding issue for more info.


This change is Reviewable

Settings : {"must_exclude":{"regex":"\\\\[ \\\\]","message":"There are incomplete TODO task(s) unchecked."}}