Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cmake): set options changes as cache and with force #2762

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

Green-Sky
Copy link
Member

@Green-Sky Green-Sky commented Jul 16, 2024

Without this, changes will not propergate to a parent if toxcore is used as a subdirectory.


This change is Reviewable

@Green-Sky Green-Sky requested a review from sudden6 July 16, 2024 09:29
@Green-Sky Green-Sky added this to the v0.2.20 milestone Jul 16, 2024
@Green-Sky
Copy link
Member Author

Green-Sky commented Jul 16, 2024

Alternatively one can use PARENT_SCOPE, but that looks more like a hack to me, since options are CACHE values.

OR we split toxcore properly into multiple libraries, but that's more of an v0.3 scope change.

Without this, changes will not propergate to a parent if
toxcore is used as a subdirectory.
@toktok-releaser toktok-releaser merged commit e9076f4 into TokTok:master Nov 6, 2024
61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants