Development #44
Merged
Development #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also, we did some code cleaning with isort and black linters.
now the sagas would contain data["platform._id"] and we would fetch the guild id from here and other things could run the same as before. Note: tests needs to be updated!
Update codes with new CC db structure
fix: credentials reading!
fix: typo platformId!
fix: typo on collection names and adding service startup logs
Previously we were reading the platformId as a string and sending the the find function but we had to convert it to bson.ObjectId
- There seem the codeclimate is giving weird errors.
Fix platform id type
- As the selectedChannels in CC is updated to just an array of Ids, we needed to remove the id fetching from discord-analyzer.
and removing the unused parts of the code.
…ding Update selected channels reading
…ding Add more logs
- It was creating another property but we needed the isInProgress under the metadata to be updated. - Also we deleted the un-informative logs. they were just for testing
…ding fix: The isInProgress was not updating the right field!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.